Skip to content

Add LOG_DIR variable to README#16

Merged
p- merged 2 commits intomainfrom
p--log-dir
Dec 11, 2025
Merged

Add LOG_DIR variable to README#16
p- merged 2 commits intomainfrom
p--log-dir

Conversation

@p-
Copy link
Copy Markdown
Contributor

@p- p- commented Dec 11, 2025

Added LOG_DIR environment variable for logging.

Added LOG_DIR environment variable for logging.
Copilot AI review requested due to automatic review settings December 11, 2025 14:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the LOG_DIR environment variable to the README.md documentation. The variable is set to /app/logs and appears alongside other environment variables like MEMCACHE_STATE_DIR, CODEQL_DBS_BASE_PATH, and DATA_DIR that are used to configure directory paths for the SecLab Taskflow Agent.

  • Adds LOG_DIR=/app/logs to the environment variables configuration example

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment on lines +9 to 11
LOG_DIR=/app/logs
```

Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LOG_DIR environment variable is added to the configuration example but is not actually used anywhere in the codebase. All logging configurations use the log_file_name function from seclab_taskflow_agent.path_utils, which likely manages its own log directory path. Either this variable should be integrated into the actual logging configuration, or it should be removed from the documentation if it's not currently supported.

Suggested change
LOG_DIR=/app/logs
```

Copilot uses AI. Check for mistakes.
Comment thread README.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 11, 2025 14:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@p- p- merged commit a690c2a into main Dec 11, 2025
15 checks passed
@p- p- deleted the p--log-dir branch December 11, 2025 14:45
kiandadban pushed a commit to kiandadban/seclab-taskflows that referenced this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants